Repository navigation
Pin PHP 8.4.28 / 8.5.13 for the 2026-11-19 security releases - #353
Merged
Merged
Conversation
Move the production, devcontainer and CI PHP pins to the official 8.4.28 and 8.5.13 Bookworm image indexes, raise the 8.4 runtime version guards to 80428, and update the contract tests and devcontainer README that assert the exact parent. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
The PHP pins move to the security releases of 2026-11-19 (see https://www.php.net/ChangeLog-8.php):
Dockerfilex2,.devcontainer/docker/Dockerfilex2, CI8.4)php:8.4.27-cli-bookworm@sha256:b3e907a1108629c562c4bb313ce3449e34d49991f6bb2487913f6146f47200fephp:8.4.28-cli-bookworm@sha256:85da896b3eeb8bcd83fe612e51a529b7d5983a1fab92ef5f63c7ac6e2842fc468.5)php:8.5.12-cli-bookworm@sha256:050713ce008e2360ea9dc96e1f9a075690132388d917fc3552806f7a7be6f2a0php:8.5.13-cli-bookworm@sha256:d6991172c4282d2a09d6418073923a81664173bb0a0e07a16663a9a645746092Both are official multi-arch index digests resolved from registry-1.docker.io. Each one reports the expected
PHP_VERSION.Changes:
scripts/ci/php-container-images.json: new pins for 8.4 and 8.5.Dockerfileand.devcontainer/docker/Dockerfile: new 8.4.28 pin on bothFROMlines in each file.PHP_VERSION_ID >= 80428in.devcontainer/docker/Dockerfile, and< 80428plus the error message indocker/verify-runtime-trust.php(the production image runs this guard at build time).tests/Unit/ProductionImageTrustContractTest.php,tests/ci/test_bookworm_consumer.py(accepted parent) andtests/ci/test_devcontainer_attestations.py(fixture tag strings)..devcontainer/docker/README.md: now says 8.4.28. It also states that the centraldocker/aptprofile at18783be6records the descriptors of the earlier 8.4.27 parent, not 8.4.28. The shared preflight does not depend on the parent digest: it checks the installed APT/libapt pair.Relevance
The sample-app container serves with
php artisan serve, which uses the CLI built-in web server SAPI. The fixes that matter here are the built-in server's repeated-header crash fix and the general Core, Date and Session fixes. The FPM and CGI CVEs in these releases don't apply to this image.Tests run on lab4 (Docker, capped containers)
python -m unittest discover -s tests/ci -p 'test_*.py'(python:3.13-slim): 79 OK, 1 skipped. The skipped test needs the built CI image, which the launcher provides only in CI.docker/php-ci/Dockerfilebuilt with the new 8.4 pin: builds. The probe reports8.4.28, all required extensions are loaded and the production INI is in use. The APT preflight reportsapt=2.6.2 libapt-pkg6.0=2.6.2.verify-runtime-trust.phppasses.docker/php-ci/Dockerfilebuilt with the new 8.5 pin: builds. The probe reports8.5.13with all required extensions, and the APT preflight passes.--testsuite Uniton the 8.4.28 CI image: 137 tests, 1013 assertions OK, 1 skipped.Dockerfile(--target production): builds. The new 80428 guard inverify-runtime-trust.phppasses in every stage that runs it, the APT preflight passes, the Playwright smoke test passes, and the final image reports8.4.28 cli.Left unchanged
polyglot/*/Dockerfilestill uses the floatingFROM php:8.4-clitag. The repo has no policy that requires pins there, so they pick up 8.4.28 when the tag moves.docker/php-ci/Dockerfilekeeps itscomposer:2.10.3pin. It is outside the scope of this PHP update.durable-workflow/.githubdocker/aptprofile (php-8.4.27-cli-bookworm.v1.json) is in another repo and was not changed here. Recording the 8.4.28 parent there would be a separate central change. This consumer pins the same accepted central commit and file SHA as before.docs/,docker/php-ci/).🤖 Generated with Claude Code