Skip to content

Pin PHP 8.4.28 / 8.5.13 for the 2026-11-19 security releases - #353

Merged
rmcdaniel merged 1 commit into
mainfrom
general/php-2026-11-19-pins
Nov 19, 2026
Merged

rmcdaniel merged 1 commit into
mainfrom
general/php-2026-11-19-pins

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

What changed

The PHP pins move to the security releases of 2026-11-19 (see https://www.php.net/ChangeLog-8.php):

Use Old New
8.4 (production Dockerfile x2, .devcontainer/docker/Dockerfile x2, CI 8.4) php:8.4.27-cli-bookworm@sha256:b3e907a1108629c562c4bb313ce3449e34d49991f6bb2487913f6146f47200fe php:8.4.28-cli-bookworm@sha256:85da896b3eeb8bcd83fe612e51a529b7d5983a1fab92ef5f63c7ac6e2842fc46
8.5 (CI 8.5) php:8.5.12-cli-bookworm@sha256:050713ce008e2360ea9dc96e1f9a075690132388d917fc3552806f7a7be6f2a0 php:8.5.13-cli-bookworm@sha256:d6991172c4282d2a09d6418073923a81664173bb0a0e07a16663a9a645746092

Both are official multi-arch index digests resolved from registry-1.docker.io. Each one reports the expected PHP_VERSION.

Changes:

  • scripts/ci/php-container-images.json: new pins for 8.4 and 8.5.
  • Dockerfile and .devcontainer/docker/Dockerfile: new 8.4.28 pin on both FROM lines in each file.
  • Version guards raised to 8.4.28: PHP_VERSION_ID >= 80428 in .devcontainer/docker/Dockerfile, and < 80428 plus the error message in docker/verify-runtime-trust.php (the production image runs this guard at build time).
  • Contract tests and fixtures: tests/Unit/ProductionImageTrustContractTest.php, tests/ci/test_bookworm_consumer.py (accepted parent) and tests/ci/test_devcontainer_attestations.py (fixture tag strings).
  • .devcontainer/docker/README.md: now says 8.4.28. It also states that the central docker/apt profile at 18783be6 records the descriptors of the earlier 8.4.27 parent, not 8.4.28. The shared preflight does not depend on the parent digest: it checks the installed APT/libapt pair.

Relevance

The sample-app container serves with php artisan serve, which uses the CLI built-in web server SAPI. The fixes that matter here are the built-in server's repeated-header crash fix and the general Core, Date and Session fixes. The FPM and CGI CVEs in these releases don't apply to this image.

Tests run on lab4 (Docker, capped containers)

  • python -m unittest discover -s tests/ci -p 'test_*.py' (python:3.13-slim): 79 OK, 1 skipped. The skipped test needs the built CI image, which the launcher provides only in CI.
  • docker/php-ci/Dockerfile built with the new 8.4 pin: builds. The probe reports 8.4.28, all required extensions are loaded and the production INI is in use. The APT preflight reports apt=2.6.2 libapt-pkg6.0=2.6.2. verify-runtime-trust.php passes.
  • docker/php-ci/Dockerfile built with the new 8.5 pin: builds. The probe reports 8.5.13 with all required extensions, and the APT preflight passes.
  • PHPUnit --testsuite Unit on the 8.4.28 CI image: 137 tests, 1013 assertions OK, 1 skipped.
  • Full production Dockerfile (--target production): builds. The new 80428 guard in verify-runtime-trust.php passes in every stage that runs it, the APT preflight passes, the Playwright smoke test passes, and the final image reports 8.4.28 cli.
  • Feature tests (MySQL/Redis) were not run locally; the CI matrix covers them.

Left unchanged

  • polyglot/*/Dockerfile still uses the floating FROM php:8.4-cli tag. The repo has no policy that requires pins there, so they pick up 8.4.28 when the tag moves.
  • docker/php-ci/Dockerfile keeps its composer:2.10.3 pin. It is outside the scope of this PHP update.
  • The central durable-workflow/.github docker/apt profile (php-8.4.27-cli-bookworm.v1.json) is in another repo and was not changed here. Recording the 8.4.28 parent there would be a separate central change. This consumer pins the same accepted central commit and file SHA as before.
  • I found no documented pin-update procedure in this repo (CONTRIBUTING, AGENTS.md, docs/, docker/php-ci/).

🤖 Generated with Claude Code

Move the production, devcontainer and CI PHP pins to the official
8.4.28 and 8.5.13 Bookworm image indexes, raise the 8.4 runtime
version guards to 80428, and update the contract tests and
devcontainer README that assert the exact parent.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel merged commit 46ab6a7 into main Nov 19, 2026
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:general Pull request opened by General agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant